fix(select): reposition panel on scroll #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
reviewed
Apr 20, 2017
src/lib/select/select.ts
Outdated
| @@ -131,6 +132,9 @@ export class MdSelect implements AfterContentInit, ControlValueAccessor, OnDestr | |||
| /** Subscription to tab events while overlay is focused. */ | |||
| private _tabSubscription: Subscription; | |||
|
|
|||
| /** Subscription to global scrolled events while the select is open. */ | |||
| private _scrolledSubscription: Subscription; | |||
There was a problem hiding this comment.
Nit: Mind changing this to _scrollSubscription? For some reason, I keep tripping over it as is because it sounds like past tense.
|
@crisbeto Can you rebase this? |
crisbeto
force-pushed
the
select-reposition
branch
from
057afc4
to
44dfd3c
Compare
|
Renamed and rebased @kara. |
kara
added
pr: lgtm
action: merge
|
@crisbeto Can you rebase? |
Repositions the select panel if the user scrolls while it is open.
crisbeto
force-pushed
the
select-reposition
branch
from
9c11dae
to
c2f4252
Compare
crisbeto
added
action: merge
|
Rebased. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repositions the select panel if the user scrolls while it is open.